fix(fe2): Make viewer controls scrollable when they overflow viewport #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikehrn
approved these changes
Jan 7, 2025
andrewwallacespeckle
deleted the
andrew/web-2334-smaller-screens-view-menu-clips
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a perfect solution, but it's better than it is currently.
Right now, smaller screens clip the bottom of the viewer controls. You can see my screenshot above, and i'm on a decent mac, so others will definitely experience this.
There was a weird
bg-green/0class which i removed, and then addedoverflow-y-autoto the same div.Now, when the menu overflows the viewport, our custom scrollbar appears. This should have no affect on users with large screens, but allows other users to access lower items.
@Mikehrn I discussed this one with Benjamin this morning and we talked about a larger rethink on this controls menu in the viewer. It's not worth spending time on a better solution right now, when this is all probably going to change pretty soon.