fix(workspaces): non region enabled workspace project creation #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainsproat
reviewed
Jan 20, 2025
| workspaceId: input.workspaceId | ||
| }) | ||
| if (!workspace) throw new WorkspaceNotFoundError() | ||
| await upsertWorkspaceFactory({ db: projectDb })({ workspace }) |
There was a problem hiding this comment.
Is this effectively migrating a workspace to a region from the main DB?
There was a problem hiding this comment.
yes, in the region, we only need the workspace's id to exists. Its state is stored in the mainDb always.
This was the cause of the default project region switch bug, we had two almost identical implementations...
…gergo/web-2478-copy-workspace-if-not-in-default-project-region
|
@iainsproat reviewed this in person |
gjedlicska
deleted the
gergo/web-2478-copy-workspace-if-not-in-default-project-region
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References