Replaced StreamReader.Peek() #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced Peek() function because of issue that occurs only in .net6.0 dotnet/runtime#68983 when downloading large object (e.g. 8000+ child objects)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced Peek() function because of issue that occurs only in .net6.0 when downloading large object (e.g. 8000+ child objects) using the Speckle "ServerTransport"
Description
Because of a .net6.0 issue with StreamReader.Peek() see: dotnet/runtime#68983
The ServerTransport is using the .Peek() function to find the end of the stream and stop reading more object lines.
Type of change
How has this been tested?
-The changes to the Speckle Transport have been tested in a separate console app tool referencing the Speckle.Core project. It also has been tested as a Copy/CustomTransport supplied to the Operations.Receive in various production/test environments as a quick fix, it has not been tested as part of a development build of Speckle.Core 2.6.x
Docs