Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gergo/removeDeprecatedUserQueryAgain #2684

Merged
merged 2 commits into from
Jun 21, 2023
Merged

gergo/removeDeprecatedUserQueryAgain #2684

merged 2 commits into from
Jun 21, 2023

Conversation

gjedlicska
Copy link
Contributor

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@gjedlicska gjedlicska changed the base branch from main to dev June 20, 2023 12:46
AlanRynne
AlanRynne suggested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👇🏼 Just one thing. We may want to create ActiveUserServerInfoResponse and flag UserInfoResponse as obsolete instead of renaming a property willy-nilly.

Core/Core/Credentials/AccountManager.cs
@@ -107,7 +107,7 @@ private static async Task<UserServerInfoResponse> GetUserServerInfo(string token
var request = new GraphQLRequest
{
Query =
@"query { user { id name email company avatar streams { totalCount } commits { totalCount } } serverInfo { name company adminContact description version} }"
@"query { activeUser { id name email company avatar streams { totalCount } commits { totalCount } } serverInfo { name company adminContact description version} }"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but we also have to modify (or duplicate+obsolete) the UserServerInfoResponse so that it contains an activeUser field instead of a user field, or the query will succeed but the user will be null.

@AlanRynne AlanRynne self-assigned this Jun 21, 2023
@AlanRynne AlanRynne merged commit 5c5bbfc into dev Jun 21, 2023
@AlanRynne AlanRynne deleted the gergo/removeDeprecatedUserQueryAgain branch June 21, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne requested changes

@teocomi teocomi Awaiting requested review from teocomi

@connorivy connorivy Awaiting requested review from connorivy

Assignees

@AlanRynne AlanRynne

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gjedlicska @AlanRynne