Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Revit) : new incoming types false positive #2713

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

connorivy
Copy link
Contributor

@connorivy connorivy commented Jun 29, 2023

Description & motivation

During testing, it was discovered that existing types would flag the "missing incoming types" dialog. This was the result of a mistake on my part in changing some code and then not realizing the consequences of the changes. This should fix it.

Changes:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@AlanRynne
Copy link
Contributor

Approved by Matteo so I'm merging it in!

@AlanRynne AlanRynne merged commit 7b77dad into dev Jun 30, 2023
@AlanRynne AlanRynne deleted the revit/connor/fix-new-types-false-positive branch June 30, 2023 08:51
@AlanRynne AlanRynne self-assigned this Jun 30, 2023
@AlanRynne AlanRynne added the revit issues related to the revit connector. label Jun 30, 2023
@AlanRynne AlanRynne added this to the 2.15 milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revit issues related to the revit connector.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants