fix(rhino): correct layers on create receive mode #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairekuang
commented
Jul 3, 2023
| .ToList(); | ||
| // if on create mode, make sure the parent commit layer is created first | ||
| if (state.ReceiveMode == ReceiveMode.Create) | ||
| { |
There was a problem hiding this comment.
This code chunk is where the bug fix is, along with the change in the converter
AlanRynne
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Creates correct layers on
createreceive mode in Rhino: issue was being caused by the base commit layer not being created before other layers.Also contians refactor of connector bindings to split methods into separate files.
Fixes #2710
Changes: