Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Archicad): Receive all kind of instances #2734

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Conversation

jozseflkiss
Copy link
Contributor

@jozseflkiss jozseflkiss commented Jul 5, 2023

Description & motivation

To be able to receive all kind of instances.
Found an issue during v.2.15 testing: Receiving nested hosted Revit instances results in duplicates in Archicad.

Changes:

  • hosted elements traversals: we don't traverse the "elements" field of the root BlockInstance (they will be traversed by the main element traversal)
  • transform appleid only elements via the "definition" property (not via "elements" property)
  • ArchicadDefinitionTraversal renamed to ArchicadGeometryCollector

Screenshots:

image

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

@jozseflkiss jozseflkiss requested a review from JR-Morgan July 6, 2023 08:43
@jozseflkiss jozseflkiss changed the title Archicad/instances fix(Archicad): Receive all kind of instances Jul 6, 2023
@jozseflkiss jozseflkiss requested a review from AlanRynne July 6, 2023 13:30
@JR-Morgan JR-Morgan merged commit 3ae30b9 into dev Jul 6, 2023
@JR-Morgan JR-Morgan deleted the archicad/instances branch July 6, 2023 15:19
@jozseflkiss jozseflkiss assigned jozseflkiss and unassigned JR-Morgan Jul 7, 2023
@jozseflkiss jozseflkiss removed the request for review from AlanRynne July 7, 2023 10:28
@jozseflkiss jozseflkiss added the enhancement New feature or request label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archicad enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants