feat(revit): adds fallback option to receive displayable speckle objects as directshapes #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns the logic with the viewer's selection logic, where any displayable object will be selectable as a unit, independently of how many geometries it's made of.
…fallback-when-conversion-fails
…or' into alan/revit/ds-fallback-when-conversion-fails
…or' into alan/revit/ds-fallback-when-conversion-fails
…or' into alan/revit/ds-fallback-when-conversion-fails
…fallback-when-conversion-fails
…ost element setting
teocomi
reviewed
Aug 9, 2023
ConnectorRhino/ConnectorRhino/ConnectorRhinoShared/UI/ConnectorBindingsRhino.Receive.cs
Outdated
Show resolved
Hide resolved
Objects/Converters/ConverterRevit/ConverterRevitShared/ConverterRevit.cs
Outdated
Show resolved
Hide resolved
ConnectorRevit/ConnectorRevit/UI/ConnectorBindingsRevit.Receive.cs
Outdated
Show resolved
Hide resolved
ConnectorRevit/ConnectorRevit/UI/ConnectorBindingsRevit.Receive.cs
Outdated
Show resolved
Hide resolved
teocomi
added
enhancement
This was
linked to
issues
Aug 9, 2023
teocomi
reviewed
Aug 10, 2023
ConnectorRevit/ConnectorRevit/UI/ConnectorBindingsRevit.Receive.cs
Outdated
Show resolved
Hide resolved
1 task
…ion of some conflicting changes after dev merge (#2861) * fix(core): Removed duplicated methods on `ISpeckleConverter` after non-conflicting merge * fix(rvt): Incorrectly merged chunks caused failure to build * feat(rvt): Isolated `HostElement` in new `RevitConverterState` * feat(rvt): Added directshape fallback setting * fix(rvt): Reorganized fallback to DS behaviour * feat(rvt): Added new setting for DirectShape fallback Still pending backwards compatibility with the previous setting, seems to work as intended right now * fix(rvt): Minor cleanup of fallback logic * fix(rvt): Update appObject when everything fails
AlanRynne
suggested changes
Aug 18, 2023
There was a problem hiding this comment.
Switching this to "requested changes" not because there's any changes pending on our side, but because I don't want to merge this without @connorivy express consent, as we've had to fix some rather complex conflicts that require triple checking before this goes, as it can affect the fix merged in #2849
connorivy
reviewed
Aug 22, 2023
connorivy
approved these changes
Aug 22, 2023
AlanRynne
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Amazing! Just browsed through your commit and looks great @connorivy.
Approving too in order to merge in 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This feature includes the following:
directshape receive settingso that all commit objects are received as directshapes created from their displayValue geometry. This should look exactly as the commit does in the viewer.Closes #2777
Closes #2468
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Tested receiving large revit commits with instances using the directshape setting.