Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Archicad): Add by Category selection method #2864

Merged
merged 4 commits into from
Aug 23, 2023
Merged

feat(Archicad): Add by Category selection method #2864

merged 4 commits into from
Aug 23, 2023

Conversation

jozseflkiss
Copy link
Contributor

@jozseflkiss jozseflkiss commented Aug 21, 2023 •
edited
Loading

Description & motivation

Fix of: #2780

Changes:

  • new filter implemented in ArchicadBinding
  • GetElementIds HTTP command handles element type filter

Screenshots:

image

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

@jozseflkiss jozseflkiss force-pushed the archicad/category-selection branch from b42ba46 to 652fc9b Compare August 21, 2023 09:47
@jozseflkiss jozseflkiss changed the title Add by Category selection method feat(Archicad): Add by Category selection method Aug 21, 2023
@jozseflkiss jozseflkiss linked an issue Aug 21, 2023 that may be closed by this pull request
feat(Archicad): Add by Category selection method #2780
Closed
AlanRynne
AlanRynne approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this only touches Archicad connector, I'm going to go ahead an approve this blindly 🫣

Feel free to merge in whenever you're ready @jozseflkiss

@AlanRynne AlanRynne added enhancement New feature or request archicad labels Aug 23, 2023
@jozseflkiss jozseflkiss merged commit a0bf736 into dev Aug 23, 2023
@jozseflkiss jozseflkiss deleted the archicad/category-selection branch August 23, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

@clairekuang clairekuang Awaiting requested review from clairekuang

Assignees
No one assigned
Labels
archicad enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(Archicad): Add by Category selection method
2 participants
@jozseflkiss @AlanRynne