Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DUI): Wording alignment between web and dui. Improved semantics. #2901

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

jsdbroughton
Copy link
Contributor

@jsdbroughton jsdbroughton commented Sep 8, 2023

Closes #2900

Motivation:

Improved semantics to aid the acceptance of Speckle in privacy/security interested organisations and individuals.

Changes:

  • Change the text for ToggleSwitch when IsChecked is true to "Link Shareable"

  • Change the text for ToggleSwitch when IsChecked is false to "Private"

  • increased padding between control and label text

image

- Change the text for ToggleSwitch when IsChecked is true to "Link Shareable"
- Change the text for ToggleSwitch when IsChecked is false to "Private"
@jsdbroughton jsdbroughton requested a review from teocomi September 8, 2023 17:45
@jsdbroughton jsdbroughton added desktopui issues related to the desktop ui. ✂️ paper-cut Little annoyances that pop up but you don’t feel are enough to make a fuss over labels Sep 8, 2023
@teocomi teocomi merged commit b02a5e1 into dev Sep 8, 2023
@teocomi teocomi deleted the dui/jsdb/new-stream-dialog branch September 8, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktopui issues related to the desktop ui. ✂️ paper-cut Little annoyances that pop up but you don’t feel are enough to make a fuss over
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

papercut(DUI): Semantics on new Stream status is misaligned to web FE1 & FE2
2 participants