Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (Revit) : curtain wall subelements fix #2904

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

connorivy
Copy link
Contributor

Description & motivation

Sending entire view for large models was hanging. That is because, for view specific send operations, we were retrieving (and converting) all curtain panels and mullions in the view every time that we were sending a curtain wall.

Changes:

  • for view specific send, query document for all curtain wall subelements in the active view, cache that, and compare it to the subelements of the wall being converted

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@connorivy connorivy changed the base branch from main to dev September 11, 2023 17:25
@connorivy connorivy merged commit e745053 into dev Sep 12, 2023
@connorivy connorivy deleted the revit/connor/curtain-wall-subelements-fix branch September 12, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants