Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csharpier CSI #2999

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Csharpier CSI #2999

merged 2 commits into from
Oct 24, 2023

Conversation

JR-Morgan
Copy link
Member

Renamed Partial Classes to PartialClasses.
Ran csharpier on CSI converter.

Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES 🙌🏼 May be tricky to merge this in right now though... so not approving... YET

@JR-Morgan
Copy link
Member Author

My other PR #2970 is full for formatting changes since I have been editing these files with the csharpier "on save" hook.

This makes this PR quite messy, so I was hoping that I could get this one in first (being that it's 100% formatting changes)
then hopefully the diff for #2970 will be cleaner.

If this messes other peoples PRs up however, I can hold off for a bit.

@JR-Morgan JR-Morgan changed the title Renamed project to avoid spaces in directory path Csharpier CSI Oct 23, 2023
Copy link
Contributor

@connorivy connorivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this won't be an issue for me

@JR-Morgan JR-Morgan requested a review from AlanRynne October 23, 2023 19:30
@AlanRynne
Copy link
Contributor

Fantastic! Merging in then ;)

@AlanRynne AlanRynne merged commit 6e1d7b4 into dev Oct 24, 2023
@AlanRynne AlanRynne deleted the jrm/csi/csharpier branch October 24, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants