-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(Revit) : add material quantites by mesh #3030
Conversation
…-quantites-add-by-mesh
…quantites-add-by-mesh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just got 1 change request and a bunch of questions/considerations that are non-critical.
Objects/Converters/ConverterRevit/ConverterRevitShared/ConversionUtils.cs
Show resolved
Hide resolved
Objects/Converters/ConverterRevit/ConverterRevitShared/ConversionUtils.cs
Show resolved
Hide resolved
Objects/Converters/ConverterRevit/ConverterRevitShared/ConversionUtils.cs
Outdated
Show resolved
Hide resolved
.../Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs
Show resolved
Hide resolved
.../Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs
Show resolved
Hide resolved
.../Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things to consider
Objects/Converters/ConverterRevit/ConverterRevitShared/ConversionUtils.cs
Outdated
Show resolved
Hide resolved
.../Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs
Show resolved
Hide resolved
.../Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs
Outdated
Show resolved
Hide resolved
.../Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs
Outdated
Show resolved
Hide resolved
.../Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs
Show resolved
Hide resolved
.../Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments have been resolved. We're good to go.
Added Kilian as co-author ;) |
Description & motivation
Solves issue #2117 and improves the calculation of material quantities.
There are some problems with obtaining quantities in Revit:
RevitAPI GetMaterialIds does not return all materials
Computation of area not clear
Some categories need further evaluation
Changes:
Checklist:
References
Child of this PR #2715