Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dui): broken fe2 url when in oneclick mode #3098

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

teocomi
Copy link
Member

@teocomi teocomi commented Dec 6, 2023

We forgot to add the switch in the One Click Mode.
Here's a quick fix for it that should be probably released as hotfix sometime soon.
Community report: https://speckle.community/t/rhino-speckle-connector-server-link-issue/8170/2

@teocomi teocomi added the desktopui issues related to the desktop ui. label Dec 6, 2023
@teocomi teocomi requested a review from connorivy December 9, 2023 16:42
@JR-Morgan
Copy link
Member

Haven't gotten around to test yet, but looking at the code, no objections.
Incase another reviewer approves before I get the chance to test, please make sure we resolve the formatting errors CI is throwing
(perhaps Matteo doesn't have csharpier setup correctly on his local setup).

Also, please can we remember to tag our PRs with the correct milestone. Helps for posterity, hotfix organisation, and a double check that were targeting the correct branch.

@AlanRynne
Copy link
Contributor

Also, please can we remember to tag our PRs with the correct milestone. Helps for posterity, hotfix organisation, and a double check that were targeting the correct branch.

I would second this ✋🏼

Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Revit and verified it works both in FE1 and FE2 servers

Also fixed the formatting issue and an unnecessary using statement.

Waiting for CI to merge

@AlanRynne AlanRynne merged commit 4978c10 into main Dec 11, 2023
@AlanRynne AlanRynne deleted the dui/oneclick-url-fix branch December 11, 2023 21:39
@teocomi
Copy link
Member Author

teocomi commented Dec 13, 2023

Hey folks, thanks for the merge, has this been released as hotfix?
If not, can it go out asap? It's potentially affecting the onboarding of new users.

Apologies for not following the protocol, juggling a few things right now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktopui issues related to the desktop ui.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants