Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(Revit): CNX-7577 project info custom props #3100

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Feat(Revit): CNX-7577 project info custom props #3100

merged 2 commits into from
Dec 11, 2023

Conversation

connorivy
Copy link
Contributor

@connorivy connorivy commented Dec 6, 2023 •
edited
Loading

Description & motivation

fixes https://spockle.atlassian.net/browse/CNX-7577?atlOrigin=eyJpIjoiZGEzODk0YThmY2U4NGI1MDlhM2JhZWQ3NzlmZTNmZWIiLCJwIjoiaiJ9

Changes:

  • add custom properties to the "project info" property that gets sent from Speckle

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@AlanRynne AlanRynne changed the title Feat(Revit): project info custom props Feat(Revit): CNX-7577 project info custom props Dec 11, 2023
@AlanRynne AlanRynne self-assigned this Dec 11, 2023
@AlanRynne AlanRynne self-requested a review December 11, 2023 11:56
AlanRynne
AlanRynne approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! I tested on Revit 2023 and it seems to work perfectly.

@AlanRynne AlanRynne merged commit 2d6355a into dev Dec 11, 2023
@AlanRynne AlanRynne deleted the revit/connor/project-info-custom-props branch December 11, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

Assignees

@AlanRynne AlanRynne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorivy @AlanRynne