feat(civil3d): CNX-8013 add alignment properties design speed #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanRynne
changed the title
AlanRynne
reviewed
Dec 19, 2023
.../Converters/ConverterAutocadCivil/ConverterAutocadCivilShared/ConverterAutocadCivil.Civil.cs
Show resolved
Hide resolved
.../Converters/ConverterAutocadCivil/ConverterAutocadCivilShared/ConverterAutocadCivil.Civil.cs
Show resolved
Hide resolved
AlanRynne
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Adjusts the previous pr's implementation of design speeds to include design speeds that may not be on an alignment's existing stations.
This implementation stores each design speed as a
Basewith 4 properties: the speednumber,station,value, andcomment(if exists). The list of speeds is stored as a detachedList<Base>on the alignment.https://speckle.xyz/streams/b53a53697a/commits/89b9c3e6f5
Changes: