fix(Archicad): CNX-8392 Handle CA1031 warnings in ArchiCAD projects #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozseflkiss
changed the title
AlanRynne
suggested changes
Jan 8, 2024
Comment on lines
30
to
38
| catch (ArgumentNullException) | ||
| { | ||
| return null; | ||
| } | ||
| catch (TaskCanceledException) | ||
| { | ||
| return null; | ||
| } | ||
| catch (ObjectDisposedException) |
There was a problem hiding this comment.
I'm assuming Execute cannot throw within? If so, would we want to add logging to some these since we're swallowing them?
| @@ -27,7 +27,15 @@ internal class AsyncCommandProcessor | |||
| { | |||
| return Task.Run(command.Execute, token); | |||
| } | |||
| catch (Exception e) | |||
| catch (ArgumentNullException) | |||
There was a problem hiding this comment.
I think this one is only going to throw if command.Execute is null, which can't be the case since it's part of the ICommand interface.
I think we don't really need to catch this as it would really be an unexpected event (provided input was invalid somehow)
| { | ||
| throw; | ||
| SpeckleLog.Logger.Warning("Failed to convert element type {elementType}", elementType.ToString()); |
There was a problem hiding this comment.
Warnings should also include their exception if it exists as first argument.
| } | ||
| catch (Exception) | ||
| catch (ObjectDisposedException) | ||
| { | ||
| SpeckleLog.Logger.Warning("Failed to convert element type {elementType}", elementType.ToString()); |
There was a problem hiding this comment.
Same here, including the exception makes the warning more useful in our logs.
added 2 commits
January 9, 2024 05:03
AlanRynne
approved these changes
Jan 9, 2024
| return null; | ||
| } | ||
| catch (ObjectDisposedException) | ||
| catch (Exception ex) when (ex is TaskCanceledException or ObjectDisposedException) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Handle CA1031 warnings in ArchiCAD projects
https://spockle.atlassian.net/browse/CNX-8392
Changes:
Specific exceptions used.
Checklist: