Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(core): Deprecation of SerialzierV1 + Cleanup of Operations.Receive #3125

Merged
merged 14 commits into from
Jan 10, 2024
Merged

Chore(core): Deprecation of SerialzierV1 + Cleanup of Operations.Receive #3125

merged 14 commits into from
Jan 10, 2024

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Jan 8, 2024 •
edited
Loading

  1. Deprecated Serializer V1
  2. Supressed Analyser warnings for several legacy/deprecated classes in Core
  3. Deprecated Serializer V1 overloads of Operations.Receive <- Similar with feat(Core): CNX-8352 operations.send #3094, I've tried to be as non-breaking as possible
  4. Added some unit tests for Operations.Receive (since the existing ones weren't very exhaustive)
    • Cyclomatic complexity from 24 -> 8 (and its still quite ugly)
  5. Bonus random change (sorry) Moved ApplicationObject into its own file

@JR-Morgan JR-Morgan changed the base branch from main to dev January 8, 2024 16:12
@JR-Morgan JR-Morgan marked this pull request as draft January 8, 2024 16:14
@JR-Morgan JR-Morgan requested a review from gjedlicska January 8, 2024 21:33
@JR-Morgan JR-Morgan marked this pull request as ready for review January 9, 2024 00:01
@JR-Morgan JR-Morgan changed the title Chore(core): Deprecation of SerialzierV1 Chore(core): Deprecation of SerialzierV1 + Cleanup of Operations.Receive Jan 9, 2024
@JR-Morgan JR-Morgan changed the title Chore(core): Deprecation of SerialzierV1 + Cleanup of Operations.Receive Chore(core): Deprecation of SerialzierV1 + Cleanup of Operations.Receive Jan 9, 2024
@JR-Morgan JR-Morgan marked this pull request as draft January 9, 2024 00:05
@JR-Morgan JR-Morgan force-pushed the jrm/core/deprecation branch from 08b866d to 1b44b59 Compare January 9, 2024 00:06
@JR-Morgan JR-Morgan force-pushed the jrm/core/deprecation branch 4 times, most recently from 60853f8 to ac8a8c8 Compare January 9, 2024 00:33
@JR-Morgan JR-Morgan force-pushed the jrm/core/deprecation branch from ac8a8c8 to 9ca839d Compare January 9, 2024 00:39
@JR-Morgan JR-Morgan marked this pull request as ready for review January 9, 2024 13:36
@AlanRynne AlanRynne self-assigned this Jan 10, 2024
AlanRynne
AlanRynne reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick pass over everything, but may be interesting to have a call to run through the Receive changes

@AlanRynne AlanRynne self-requested a review January 10, 2024 12:30
AlanRynne
AlanRynne reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some answers to your comments 🙂

@JR-Morgan JR-Morgan requested a review from AlanRynne January 10, 2024 13:24
AlanRynne
AlanRynne approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this after live review with Jedd

@JR-Morgan JR-Morgan force-pushed the jrm/core/deprecation branch from eea6a1f to 913e1b1 Compare January 10, 2024 18:30
@JR-Morgan JR-Morgan merged commit 1f79914 into dev Jan 10, 2024
30 checks passed
@JR-Morgan JR-Morgan deleted the jrm/core/deprecation branch January 10, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

@teocomi teocomi Awaiting requested review from teocomi

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

Assignees

@AlanRynne AlanRynne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JR-Morgan @AlanRynne