Chore(Tests): CNX-8640 core integration test project #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JR-Morgan
commented
Jan 10, 2024
•
JR-Morgan
commented
- Resolved naming violations in Integration test projects
- Updated editor config to warn when using the old nunit functions
- Updated both Unit and integration tests to use the new nunit functions
- Removed ConfigureAwaits from test project:
- My reasoning is. They aren't needed, don't provide value, just adds visual clutter.
- Happy to discuss and revert if prefered.
JR-Morgan
changed the title
JR-Morgan
changed the title
AlanRynne
approved these changes
Jan 12, 2024
Comment on lines
-67
to
-69
| _client.MaybeThrowFromGraphQLErrors(new GraphQLRequest(), new GraphQLResponse<string>()); | ||
| // We're just checking that the prev function didn't throw | ||
| Assert.True(true); |
| @@ -33,7 +33,7 @@ public void Receive_OperationCanceled_ExceptionThrown(string id) | |||
| ctc.Cancel(); | |||
|
|
|||
| MemoryTransport emptyTransport2 = new(); | |||
| Assert.ThrowsAsync<OperationCanceledException>(async () => | |||
| Assert.CatchAsync<OperationCanceledException>(async () => | |||
There was a problem hiding this comment.
Is CatchAsync the recommended pattern to assert an exception type here? Asking out of ignorance
There was a problem hiding this comment.
ThrowsAsync tests if the method throws the EXACT type
CatchAsync allows subtypes
In this case, the spirit of the test was to make sure it an OperationCancelledException, we don't care if its a subtype like TaskCancelledException, so I after learning of the existence of CatchAsync, I decided to update the functions where we would be ok with subtypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.