Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Automate): CNX-8610 automate sdk warnings #3132

Merged
merged 10 commits into from
Jan 12, 2024
Merged

Fix(Automate): CNX-8610 automate sdk warnings #3132

merged 10 commits into from
Jan 12, 2024

Conversation

oguzhankoral
Copy link
Member

Fixing all warnings on Automate.SDK and it's test project. And added README for test project.

AlanRynne
AlanRynne suggested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice overall! O warnings 🙌🏼 Just have some comments on a couple things

JR-Morgan
JR-Morgan requested changes Jan 12, 2024
View reviewed changes
Copy link
Member

@JR-Morgan JR-Morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change please. Can you uncomment these lines in the automate csproj

speckle-sharp/Automate/Speckle.Automate.Sdk/Speckle.Automate.Sdk.csproj

Lines 15 to 17 in 4978c10

<!-- <PropertyGroup Condition="'$(IsDesktopBuild)' == false">-->
<!-- <TreatWarningsAsErrors>true</TreatWarningsAsErrors>-->
<!-- </PropertyGroup>-->

And also copy these lines to the automate test project.

These will make any warnings fail in CI, so there's no chance of any warnings being shipped now once this change is made!

JR-Morgan
JR-Morgan approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@JR-Morgan JR-Morgan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are resolved,
Ty @oguzhankoral

AlanRynne
AlanRynne approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this! 🚀

@AlanRynne AlanRynne merged commit 50e468d into dev Jan 12, 2024
30 checks passed
@AlanRynne AlanRynne deleted the CNX-8610-Automate-SDK branch January 12, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

@JR-Morgan JR-Morgan JR-Morgan approved these changes

@gjedlicska gjedlicska Awaiting requested review from gjedlicska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oguzhankoral @AlanRynne @JR-Morgan