fix(core): CNX-8692 Fixed regression with AccountManager updating accounts while loading them from SQLite #3138
Conversation
JR-Morgan
requested review from
clairekuang,
AlanRynne,
teocomi,
connorivy and
jozseflkiss
as code owners
| @@ -257,8 +257,10 @@ public void UpdateObject(string hash, string serializedObject) | |||
| { | |||
| CancellationToken.ThrowIfCancellationRequested(); | |||
|
|
|||
| using var c = new SqliteConnection(_connectionString); | |||
There was a problem hiding this comment.
Our AccountManager does some potentially sketchy operations calling UpdateObject while looping through the lazily enumerate return of GetAllObjects. This causes GetAllObjects to return forever, since it returns your updated objects also.
Reverting my change so GetAllObjects and UpdateObject use separate SQLite connections appears to fix things.
I'm a little concerned that we're actually relying on some sort of in-memory cache that the connections use.
I question if this is the behaviour we actually want, it seems to me the problem is with the way the AccountManager is enumerating over a lazy enumerable that its updating. I'll open a ticket for next release to decide on what our desired behaviour here should be.
There was a problem hiding this comment.
I agree. We should do some investigation as to why this is the way it works now, as this sounds super dodgy...
| @@ -257,8 +257,10 @@ public void UpdateObject(string hash, string serializedObject) | |||
| { | |||
| CancellationToken.ThrowIfCancellationRequested(); | |||
|
|
|||
| using var c = new SqliteConnection(_connectionString); | |||
There was a problem hiding this comment.
I agree. We should do some investigation as to why this is the way it works now, as this sounds super dodgy...
JR-Morgan
force-pushed
the
CNX-8692-GetAccounts-information-continuously-queried-from-server
branch
from
d533c1e to
d5d8396
Compare
JR-Morgan
force-pushed
the
CNX-8692-GetAccounts-information-continuously-queried-from-server
branch
from
d5d8396 to
f915518
Compare
JR-Morgan
force-pushed
the
CNX-8692-GetAccounts-information-continuously-queried-from-server
branch
from
2dc7cea to
4f423bb
Compare
…-queried-from-server
AlanRynne
deleted the
CNX-8692-GetAccounts-information-continuously-queried-from-server
branch
|
Merging in! Remember to open a ticket for the unresolved conversation above @JR-Morgan 🙌🏼 |
No description provided.