fix(dynamo): CNX-8394 Handle CA1031 warnings in Dynamo projects #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-Morgan
reviewed
Jan 17, 2024
JR-Morgan
reviewed
Jan 17, 2024
JR-Morgan
reviewed
Jan 17, 2024
JR-Morgan
approved these changes
Jan 17, 2024
AlanRynne
deleted the
CNX-8394-Handle-CA1031-warnings-in-Dynamo-projects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://spockle.atlassian.net/browse/CNX-8394
Here goes nothing! I have to confess I've had to held back on refactoring half the codebase here... so I've made heavy use of
IsFatalas there were places where it was unclear what could be thrown.PR removes all CA1031 warnings from the Dynamo project, and a minor refactor of 1 horrible method with an very old angry comment above it 😅