Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test(core): CNX-8745 - Added unit test for logger #3147

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Test(core): CNX-8745 - Added unit test for logger #3147

merged 5 commits into from
Jan 18, 2024

Conversation

JR-Morgan
Copy link
Member

Not exhaustive, just testing the console logging + context properties

@JR-Morgan JR-Morgan added the core issues related to the .net sdk. label Jan 18, 2024
@JR-Morgan JR-Morgan added this to the 2.18 milestone Jan 18, 2024
AlanRynne
AlanRynne approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! We could be more exhaustive but it is a good start as a reference for breaking behaviour

@AlanRynne AlanRynne merged commit af09435 into dev Jan 18, 2024
32 checks passed
@AlanRynne AlanRynne deleted the CNX-8745-Unit-test-for-Logging branch January 18, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

@oguzhankoral oguzhankoral Awaiting requested review from oguzhankoral

Assignees
No one assigned
Labels
core issues related to the .net sdk.
Projects
None yet
Milestone
2.18
Development

Successfully merging this pull request may close these issues.
2 participants
@JR-Morgan @AlanRynne