Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(build): CNX-8713 CNX-8572 CNX-8389: Enforce no more warning (Unique Analyser codes) for SDK projects #3148

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Jan 18, 2024

  • For CI builds only:
    • Added TreatWarningsAsErrors on all SDK projects
    • Added existing warning codes as WarningsNotAsErrors

This means that no new types of warnings can be introduced without CI erroring.
It won't stop new violations of any of the existing types.

Remaining Warnings in Objects

      69 | IDE1006 
      33 | CA1819 
      26 | CA1034 
      11 | IDE0060 
       9 | CA1708 
       7 | CA2225 
       6 | CA2201 
       5 | CA1711 
       4 | CA1008 
       4 | CA1724 
       4 | CS0728 
       3 | CA1716 
       2 | CA1024 
       1 | CA1051 
       1 | CA1065 
       1 | CA1725 
       1 | CS0659 
       1 | CS0661 
       1 | IDE0041 

Remaining Warnings in Core

      59 | IDE1006 
      10 | CA1003 
       8 | CA1051 
       8 | CA1724 
       7 | CA1710 
       5 | CS8600 
       5 | CS8602 
       4 | CA1000 
       3 | CA1063 
       3 | CA1502 
       3 | CA1720 
       3 | CA1851 
       3 | CS0618 
       3 | CS8604 
       2 | CA1708 
       2 | CA1711 
       2 | CA2201 
       2 | CS8603 
       2 | IDE0032 
       2 | IDE0059 
       2 | IDE0130 
       1 | CA1001 
       1 | CA1024 
       1 | CA1033 
       1 | CA1034 
       1 | CA1055 
       1 | CA1065 
       1 | CA1506 
       1 | CA1716 
       1 | CA1721 
       1 | CA1816 
       1 | CA1861 
       1 | CS0659 
       1 | CS0809 

@JR-Morgan JR-Morgan force-pushed the CNX-8713-Enforce-Resolved-Warnings-as-Errors-In-CI branch from 5b006ee to 2bbe241 Compare January 18, 2024 17:21
@JR-Morgan JR-Morgan marked this pull request as ready for review January 19, 2024 15:11
@JR-Morgan JR-Morgan changed the title Enforce no more warning (Unique Analyser codes) for SDK projects CNX-8713: Enforce no more warning (Unique Analyser codes) for SDK projects Jan 19, 2024
@JR-Morgan JR-Morgan changed the title CNX-8713: Enforce no more warning (Unique Analyser codes) for SDK projects Chore(build): CNX-8713: Enforce no more warning (Unique Analyser codes) for SDK projects Jan 19, 2024
@JR-Morgan JR-Morgan added this to the 2.18 milestone Jan 19, 2024
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes were made while reviewed by me and claire.

Double checked everything now and it looks good

@AlanRynne AlanRynne changed the title Chore(build): CNX-8713: Enforce no more warning (Unique Analyser codes) for SDK projects Chore(build): CNX-8713 CNX-8572 CNX-8389: Enforce no more warning (Unique Analyser codes) for SDK projects Jan 22, 2024
@AlanRynne AlanRynne merged commit ffcaa9f into dev Jan 22, 2024
32 checks passed
@AlanRynne AlanRynne deleted the CNX-8713-Enforce-Resolved-Warnings-as-Errors-In-CI branch January 22, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants