Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Archicad): Archicad Connector UI finalization #3149

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

jozseflkiss
Copy link
Contributor

@jozseflkiss jozseflkiss commented Jan 22, 2024

Description & motivation

Fix of https://spockle.atlassian.net/browse/CNX-8589.

Changes:

Moving from beta to production some UI glitches should be fixed:

  • Flashing API Calls window on Archicad side when sending data
    • subelement export logic has been changed: earlier subelements (door, window and skylight) were exported during the export of the parent and extra calls were initiated to Archicad to get subelement information. Now fenestration elements (door, window and skylight) are exported separately, and connected under the "elements" property of the parent element after.
    • as a result of this, export speed has been improved a lot (Archicad sample building export time 2-3x faster than before)
  • Remove command line window on Windows
    • VS project changed from Exe to WinExe
    • DUI2 close event is not canceled when pressing close button of the UI
    • Application icon added
  • Use ApplicationObject and correct reporting during send
    • ApplicationObjects used during send operation as well
  • Reliable progress meter update during send and receive
    • A good-enough implementation of progress bar is introduced

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

@jozseflkiss jozseflkiss requested a review from AlanRynne January 22, 2024 10:18
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no deal-breakers here. Should be tested once WIP is out.

@AlanRynne AlanRynne merged commit f1ef2ab into dev Jan 23, 2024
32 checks passed
@AlanRynne AlanRynne deleted the archicad/ui-finalization branch January 23, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants