fix(Archicad): Receive slowed down in Archicad 26 #3154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
https://spockle.atlassian.net/browse/CNX-8760
Changes:
It seems that Archciad 26 has a bug. When e.g. passing
%lf
toGS::String::SPrintf
, it does not iterate on all the format specifier options available for both double and float, just takes the first one, which in this case is%f
. After that it compares the sizes:%f
-->float
(4 bytes), the passed argument wasdouble
(8 bytes). This size mismatch creates a log entry in the log file which takes so much time per vertex of a mesh being imported.In Archicad 27 this seems to be solved.
Since the string representation of the vertex written into GDL was not and should not be so precise (enough to have 8 digits), the fix is to cast the parameters to
float
-s.Checklist: