Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): CNX-8841 Fix StreamWrapper.ToString() so that it is not FE1 hardcoded #3159

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

AlanRynne
Copy link
Contributor

https://spockle.atlassian.net/browse/CNX-8831
Based on Account.serverInfo.frontend2 first, then matching regex to originalInput, then defaulting to FE1

Also added NotSupportedException for federation models

Based on Account.serverInfo.frontend2 first, then matching regex to originalInput, then defaulting to FE1

Also added NotSupportedException for federation models
@AlanRynne AlanRynne marked this pull request as draft February 1, 2024 11:54
@AlanRynne AlanRynne requested a review from JR-Morgan February 1, 2024 11:54
@AlanRynne
Copy link
Contributor Author

Draft to discuss with @JR-Morgan

@JR-Morgan JR-Morgan added this to the 2.18 milestone Feb 1, 2024
@AlanRynne AlanRynne marked this pull request as ready for review February 2, 2024 10:45
@AlanRynne AlanRynne changed the title fix(core): CNX-8831 Fix StreamWrapper.ToString() so that it is not FE1 hardcoded fix(core): CNX-8841 Fix StreamWrapper.ToString() so that it is not FE1 hardcoded Feb 6, 2024
@AlanRynne AlanRynne merged commit a674151 into dev Feb 7, 2024
30 of 32 checks passed
@AlanRynne AlanRynne deleted the CNX-8831-StreamWrapper-ToString-FE2 branch February 7, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants