Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce the minimum 1 objectId is in the automate result case #3168

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

gjedlicska
Copy link
Contributor

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link
Member

@clairekuang clairekuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the XML comments on the attachXToObjects methods to include this exception? So devs will have a heads up they shouldn't be passing empty lists

Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added XML comments and approving

@AlanRynne AlanRynne dismissed clairekuang’s stale review February 14, 2024 15:27

Review comments were adressed

@AlanRynne AlanRynne merged commit 366dde6 into dev Feb 14, 2024
32 checks passed
@AlanRynne AlanRynne deleted the gergo/automateSdkEnforceObjectsInStatusReport branch February 14, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants