bug(rhino): fixes missing user strings on nested instances when receiving #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanRynne
approved these changes
Feb 9, 2024
Comment on lines
+95
to
+126
| private void SetUserInfo(Base obj, ObjectAttributes attributes) | ||
| { | ||
| // set user strings | ||
| if (obj[UserStrings] is Base userStrings) | ||
| { | ||
| foreach (var member in userStrings.GetMembers(DynamicBaseMemberType.Dynamic)) | ||
| { | ||
| attributes.SetUserString(member.Key, member.Value as string); | ||
| } | ||
| } | ||
|
|
||
| // set name or label | ||
| var name = obj["name"] as string ?? obj["label"] as string; // gridlines have a "label" prop instead of name? | ||
| if (name != null) | ||
| { | ||
| attributes.Name = name; | ||
| } | ||
|
|
||
| // set revit parameters as user strings | ||
| if (obj["parameters"] is Base parameters) | ||
| { | ||
| foreach (var member in parameters.GetMembers(DynamicBaseMemberType.Dynamic)) | ||
| { | ||
| if (member.Value is Objects.BuiltElements.Revit.Parameter parameter) | ||
| { | ||
| var convertedParameter = ParameterToNative(parameter); | ||
| var paramName = $"{convertedParameter.Item1}({member.Key})"; | ||
| attributes.SetUserString(paramName, convertedParameter.Item2); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Given that these changes are replicated both in connector and converter, this could do with some SharedResources project in Rhino to hold all these types of shared implementations.
Since we're already looking at DI and DUI3, I don't think this is a blocker for this PR, but worth keeping in mind for the use-case
There was a problem hiding this comment.
yeah, there are some minor differences due to dependency issues, but since we are baking some objects in the connector and some in the converter, shared resources would be great to have
AlanRynne
deleted the
CNX-8670-Rhino-nested-instances-are-not-received-with-their-user-strings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Adds missing user strings to nested blocks when converting to native. Refer to this community post for more info: https://speckle.community/t/questions-about-nested-blocks-from-rhino/8955/3
Validation of changes:
Receive this commit: https://latest.speckle.dev/streams/3f895e614f/commits/ff0ab3fe69