feat(DUI2): Cnx 9068 update dui2 to use new fe2 terminology #3200
Conversation
DesktopUI2/DesktopUI2/ViewModels/MappingTool/MappingsViewModel.cs
Outdated
Show resolved
Hide resolved
| { | ||
| return JsonConvert.DeserializeObject<Config>(newConfig); | ||
| deserializedConfig.UseFe2 = true; |
There was a problem hiding this comment.
Am I correct in saying that UseFe2 will always be true after this.
No more FE1 terminology.
If that's the case, would we be able to kill the Fe2TextValueConverter and Formatting.ReplaceTerminology
Maybe not now, but we may want to do this eventually. Are there any advantages to keep it?
There was a problem hiding this comment.
Update to the decision: we'll open a separate ticket to deprecate terminology-switching code
There was a problem hiding this comment.
Update no. 2: I've decided to remove everything because it was about the same amount of work amending the previous pr anyways
| @@ -535,7 +535,7 @@ private void GenerateMenuItems() | |||
| new MenuItemViewModel(LaunchManagerCommand, "Manage accounts in Manager", MaterialIconKind.AccountCog) | |||
| ); | |||
|
|
|||
| menu.Items.Add(new MenuItemViewModel(RefreshCommand, "Refresh streams & accounts", MaterialIconKind.Refresh)); | |||
| menu.Items.Add(new MenuItemViewModel(RefreshCommand, $"Refresh projects & accounts", MaterialIconKind.Refresh)); | |||
There was a problem hiding this comment.
A few of these strings have an unnecessary $
Perhaps we can quickly remove them before his pr is merged
| @@ -199,7 +195,7 @@ | |||
| <StackPanel> | |||
| <TextBlock | |||
| IsVisible="{Binding !Commits.Count}" | |||
| Text="{Binding UseFe2, Converter={StaticResource Fe2TextValueConverter}, ConverterParameter='This branch has no commits. Commits are generated what data is sent to a Branch in a Stream.

Please select a different Branch or Stream.'}" | |||
| Text="This model has no version. Versions are generated what data is sent to a model in a project.

Please select a different model or project." | |||
There was a problem hiding this comment.
Change in pluralisation. Was this intended?
"This branch has no commits"
"This model has no version"
(I think either is fine, just want to make sure this change was intentional
JR-Morgan
deleted the
CNX-9068-DUI2-Update-to-use-new-FE2-Terminology
branch
Description & motivation
A button that serves as a global config toggle for fe2 terminology was previously implemented in the home view of DUI2, and used in conjunction with
fe2valueconverterto toggle terminology in the home view. In the stream view, the account was used to determine the value ofUseFe2irrespective of the config value.This pr: