Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(Core) : [CNX-8816] Add account upgrade method #3205

Merged
merged 29 commits into from
Mar 11, 2024
Merged

Feat(Core) : [CNX-8816] Add account upgrade method #3205

merged 29 commits into from
Mar 11, 2024

Conversation

connorivy
Copy link
Contributor

Description & motivation

Add method for account upgrade. This is to be used from manager

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

teocomi and others added 27 commits January 26, 2024 09:34
@teocomi
feat(dui): adds support for updating stream cards to FE2
3465d8a
@teocomi
Core/upgrade account (#3152)
7f0967d 
feat(core): adds upgrade account method in account manager
@teocomi
fix: var name
3245b45
edit server info
11dce44
change accountManager queries
29a5499
fix formatting
6ace471
Merge remote-tracking branch 'origin/dui/stream-card-fe2-upgrade' int…
f143115 
…o core/connor/server-info
Merge branch 'core/connor/server-info' into CNX-9043-Update-serverInf…
38a23f3 
…o-return-type-and-queries-to-include-new-migration-property
update formatting
92ce39f
add server version check
81caacc
Revert "Merge remote-tracking branch 'origin/dui/stream-card-fe2-upgr…
776015f 
…ade' into core/connor/server-info"

This reverts commit f143115, reversing
changes made to 6ace471.
Merge branch 'core/connor/server-info' into CNX-9043-Update-serverInf…
4e448e5 
…o-return-type-and-queries-to-include-new-migration-property
add matteo's Upgrade method
8df6323
remove out of scope function
7a88eba
add upgrade account method
458be38
addressed comments
1154113
more addressed comments
84356a1
remove deprecated method and fix string comparison
b91c04d
Merge branch 'CNX-9043-Update-serverInfo-return-type-and-queries-to-i…
482015e 
…nclude-new-migration-property' into core/connor/server-info
remove unused import
89590a3
Merge branch 'CNX-9043-Update-serverInfo-return-type-and-queries-to-i…
af7e36c 
…nclude-new-migration-property' into core/connor/server-info
@connorivy
Merge branch 'main' into CNX-9043-Update-serverInfo-return-type-and-q…
140e08a 
…ueries-to-include-new-migration-property
only capture first 3 numbers in server version
2a60988
remove unused import
625e7a3
Merge branch 'CNX-9043-Update-serverInfo-return-type-and-queries-to-i…
ff6cab1 
…nclude-new-migration-property' into core/connor/server-info
Merge remote-tracking branch 'origin/main' into core/connor/server-info
641a516
make comment slightly more helpful
1a419d2
AlanRynne
AlanRynne approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but the history has 27 commits which seems odd considering it's just 1 method change in 1 class.

I'm approving since we're squashing this, but it could indicate we did some weird cross-branch merges throughout the process

@AlanRynne AlanRynne requested a review from JR-Morgan March 10, 2024 15:30
@connorivy connorivy changed the title Feat(Core) : Add account upgrade method Feat(Core) : [CNX-8816] Add account upgrade method Mar 11, 2024
@BovineOx BovineOx self-requested a review March 11, 2024 16:36
@BovineOx BovineOx merged commit a5432d6 into main Mar 11, 2024
32 checks passed
@BovineOx BovineOx deleted the core/connor/server-info branch March 11, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

@BovineOx BovineOx BovineOx approved these changes

@JR-Morgan JR-Morgan Awaiting requested review from JR-Morgan

Assignees

@BovineOx BovineOx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorivy @AlanRynne @BovineOx @teocomi