CNX-8920 use account migration when selecting accounts in sdk #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BovineOx
commented
Mar 12, 2024
BovineOx
commented
- Ensuring accounts migrated to a new server are returned first
- Ensuring we have no duplicate accounts (by ID)
- Unit test added from Jedd's branch (and reviewed)
Changes to ensure they are aware of the movedFrom property added for server migration
…#3215) * Unit tests * teardown * More test cases * polish
removing duplicate accounts from those returned from GetAccounts(), where the account ID matches but is essentially the same as the account coming from the upgraded account.
JR-Morgan
approved these changes
Mar 12, 2024
JR-Morgan
requested changes
Mar 12, 2024
Updated summary comment
JR-Morgan
approved these changes
Mar 12, 2024
Added .TrimEnd('/') when setting the ServerInfo.url
AlanRynne
changed the title
Account unit tests
AlanRynne
approved these changes
Mar 12, 2024
AlanRynne
deleted the
CNX-8920-Use-Account-migration-when-selecting-accounts-in-SDK
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.