Hotfix(metrics): CNX-9196 add object type event tracking for mixpanel in autocad, rhino, and revit

ConnectorAutocadCivil/ConnectorAutocadCivil/UI/ConnectorBindingsAutocadCivil.Receive.cs

@@ -111,6 +111,9 @@ string id
         var conversionProgressDict = new ConcurrentDictionary<string, int>();
         conversionProgressDict["Conversion"] = 0;
 
+        // track object types for mixpanel logging
+        Dictionary<string, int> typeCountDict = new();
+
         // create a commit prefix: used for layers and block definition names
         var commitPrefix = Formatting.CommitInfo(stream.name, state.BranchName, id);
 
@@ -217,20 +220,30 @@ string id
             return;
           }
 
-          // convert base (or base fallback values) and store in appobj converted prop
-          if (commitObj.Convertible)
+          if (StoredObjects.TryGetValue(commitObj.OriginalId, out Base commitBaseObj))
           {
-            if (StoredObjects.TryGetValue(commitObj.OriginalId, out Base obj))
+            // log received object type
+            if (typeCountDict.TryGetValue(commitBaseObj.speckle_type, out int value))
             {
-              converter.Report.Log(commitObj); // Log object so converter can access
-              commitObj.Converted = ConvertObject(obj, converter);
+              typeCountDict[commitBaseObj.speckle_type] = ++value;
             }
             else
             {
-              commitObj.Update(status: ApplicationObject.State.Failed, logItem: "Object not found in StoredObjects");
+              typeCountDict.Add(commitBaseObj.speckle_type, 1);
             }
           }
           else
+          {
+            commitObj.Update(status: ApplicationObject.State.Failed, logItem: "Object not found in StoredObjects");
+          }
+
+          // convert base (or base fallback values) and store in appobj converted prop
+          if (commitObj.Convertible)
+          {
+            converter.Report.Log(commitObj); // Log object so converter can access
+            commitObj.Converted = ConvertObject(commitBaseObj, converter);
+          }
+          else
           {
             foreach (ApplicationObject fallback in commitObj.Fallback)
             {
@@ -271,6 +284,21 @@ string id
         }
         progress.Report.Merge(converter.Report);
 
+        // track the object type counts as an event before we try to receive
+        // this will tell us the composition of a commit the user is trying to receive, even if it's not successfully received
+        // we are capped at 255 properties for mixpanel events, so we need to check dict entries
+        var typeCountArray = typeCountDict
+          .ToArray()
+          .Select(o => new { TypeName = o.Key, Count = o.Value })
+          .OrderBy(pair => pair.Count)
+          .Reverse()
+          .Take(250);
+
+        Analytics.TrackEvent(
+          Analytics.Events.ConvertToNative,
+          new Dictionary<string, object>() { { "typeCount", typeCountArray } }
+        );
+
         // add applicationID xdata before bake
         if (!ApplicationIdManager.AddApplicationIdXDataToDoc(Doc, tr))
         {

ConnectorAutocadCivil/ConnectorAutocadCivil/UI/ConnectorBindingsAutocadCivil.Send.cs

@@ -179,6 +179,9 @@ ref int convertedCount
         var commitLayerObjects = new Dictionary<string, List<Base>>();
         var commitCollections = new Dictionary<string, Collection>();
 
+        // track object types for mixpanel logging
+        Dictionary<string, int> typeCountDict = new();
+
         foreach (var autocadObjectHandle in state.SelectedObjectIds)
         {
           // handle user cancellation
@@ -201,6 +204,17 @@ ref int convertedCount
             continue;
           }
 
+          // log selection object type
+          var objectType = obj.GetType().ToString();
+          if (typeCountDict.TryGetValue(objectType, out int value))
+          {
+            typeCountDict[objectType] = ++value;
+          }
+          else
+          {
+            typeCountDict.Add(objectType, 1);
+          }
+
           // create applicationobject for reporting
           Base converted = null;
           var descriptor = ObjectDescriptor(obj);
@@ -342,6 +356,21 @@ bool isOldApplicationId(string appId)
 
         #endregion
 
+        // track the object type counts as an event before we try to send
+        // this will tell us the composition of a commit the user is trying to convert and send, even if it's not successfully converted or sent
+        // we are capped at 255 properties for mixpanel events, so we need to check dict entries
+        var typeCountArray = typeCountDict
+          .ToArray()
+          .Select(o => new { TypeName = o.Key, Count = o.Value })
+          .OrderBy(pair => pair.Count)
+          .Reverse()
+          .Take(250);
+
+        Analytics.TrackEvent(
+          Analytics.Events.ConvertToSpeckle,
+          new Dictionary<string, object>() { { "typeCount", typeCountArray } }
+        );
+
         tr.Commit();
       }
     }

ConnectorRevit/ConnectorRevit/UI/ConnectorBindingsRevit.Receive.cs

@@ -53,6 +53,9 @@ public override async Task<StreamState> ReceiveStream(StreamState state, Progres
 
     converter.SetConverterSettings(settings);
 
+    // track object types for mixpanel logging
+    Dictionary<string, int> typeCountDict = new();
+
     Commit myCommit = await ConnectorHelpers.GetCommitFromState(state, progress.CancellationToken);
     state.LastCommit = myCommit;
     Base commitObject = await ConnectorHelpers.ReceiveCommit(myCommit, state, progress);
@@ -70,8 +73,34 @@ await ConnectorHelpers.TryCommitReceived(
     foreach (var previewObj in Preview)
     {
       progress.Report.Log(previewObj);
+      if (StoredObjects.TryGetValue(previewObj.OriginalId, out Base previewBaseObj))
+      {
+        if (typeCountDict.TryGetValue(previewBaseObj.speckle_type, out int value))
+        {
+          typeCountDict[previewBaseObj.speckle_type] = ++value;
+        }
+        else
+        {
+          typeCountDict.Add(previewBaseObj.speckle_type, 1);
+        }
+      }
     }
 
+    // track the object type counts as an event before we try to receive
+    // this will tell us the composition of a commit the user is trying to convert and receive, even if it's not successfully converted or received
+    // we are capped at 255 properties for mixpanel events, so we need to check dict entries
+    var typeCountArray = typeCountDict
+      .ToArray()
+      .Select(o => new { TypeName = o.Key, Count = o.Value })
+      .OrderBy(pair => pair.Count)
+      .Reverse()
+      .Take(250);
+
+    Analytics.TrackEvent(
+      Analytics.Events.ConvertToNative,
+      new Dictionary<string, object>() { { "typeCount", typeCountArray } }
+    );
+
     converter.ReceiveMode = state.ReceiveMode;
     // needs to be set for editing to work
     var previousObjects = new StreamStateCache(state);

ConnectorRevit/ConnectorRevit/UI/ConnectorBindingsRevit.Send.cs

@@ -99,6 +99,9 @@ public override async Task<string> SendStream(StreamState state, ProgressViewMod
     var conversionProgressDict = new ConcurrentDictionary<string, int> { ["Conversion"] = 0 };
     var convertedCount = 0;
 
+    // track object types for mixpanel logging
+    Dictionary<string, int> typeCountDict = new();
+
     await APIContext
       .Run(() =>
       {
@@ -114,6 +117,17 @@ await APIContext
             break;
           }
 
+          // log selected object type
+          string revitObjectType = revitElement.GetType().ToString();
+          if (typeCountDict.TryGetValue(revitObjectType, out int value))
+          {
+            typeCountDict[revitObjectType] = ++value;
+          }
+          else
+          {
+            typeCountDict.Add(revitObjectType, 1);
+          }
+
           bool isAlreadyConverted = GetOrCreateApplicationObject(
             revitElement,
             converter.Report,
@@ -136,10 +150,12 @@ out ApplicationObject reportObj
 
             Base result = ConvertToSpeckle(revitElement, converter);
 
+            // log converted object
             reportObj.Update(
               status: ApplicationObject.State.Created,
               logItem: $"Sent as {ConnectorRevitUtils.SimplifySpeckleType(result.speckle_type)}"
             );
+
             if (result.applicationId != reportObj.applicationId)
             {
               SpeckleLog.Logger.Information(
@@ -180,6 +196,21 @@ out ApplicationObject reportObj
       throw new SpeckleException("Zero objects converted successfully. Send stopped.");
     }
 
+    // track the object type counts as an event before we try to send
+    // this will tell us the composition of a commit the user is trying to convert and send, even if it's not successfully converted or sent
+    // we are capped at 255 properties for mixpanel events, so we need to check dict entries
+    var typeCountArray = typeCountDict
+      .ToArray()
+      .Select(o => new { TypeName = o.Key, Count = o.Value })
+      .OrderBy(pair => pair.Count)
+      .Reverse()
+      .Take(250);
+
+    Analytics.TrackEvent(
+      Analytics.Events.ConvertToSpeckle,
+      new Dictionary<string, object>() { { "typeCount", typeCountArray } }
+    );
+
     commitObjectBuilder.BuildCommitObject(commitObject);
 
     var transports = new List<ITransport>() { new ServerTransport(client.Account, streamId) };

ConnectorRhino/ConnectorRhino/ConnectorRhinoShared/UI/ConnectorBindingsRhino.Receive.cs

@@ -55,6 +55,9 @@ public override async Task<StreamState> ReceiveStream(StreamState state, Progres
     var conversionProgressDict = new ConcurrentDictionary<string, int>();
     conversionProgressDict["Conversion"] = 0;
 
+    // track object types for mixpanel logging
+    Dictionary<string, int> typeCountDict = new();
+
     Base commitObject = null;
     if (Preview.Count == 0)
     {
@@ -161,6 +164,7 @@ await ConnectorHelpers.TryCommitReceived(
             .Where(o => !string.IsNullOrEmpty(o))
             .OrderBy(path => path.Count(c => c == ':'))
             .ToList();
+
           // if on create mode, make sure the parent commit layer is created first
           if (state.ReceiveMode == ReceiveMode.Create)
           {
@@ -185,6 +189,7 @@ await ConnectorHelpers.TryCommitReceived(
             var collection = Preview
               .Where(o => o.Container == container && o.Descriptor.Contains("Collection"))
               .FirstOrDefault();
+
             if (collection != null)
             {
               var storedCollection = StoredObjects[collection.OriginalId];
@@ -217,6 +222,19 @@ await ConnectorHelpers.TryCommitReceived(
 
           foreach (var previewObj in Preview)
           {
+            // log received object type
+            if (StoredObjects.TryGetValue(previewObj.OriginalId, out Base previewBaseObj))
+            {
+              if (typeCountDict.TryGetValue(previewBaseObj.speckle_type, out int value))
+              {
+                typeCountDict[previewBaseObj.speckle_type] = ++value;
+              }
+              else
+              {
+                typeCountDict.Add(previewBaseObj.speckle_type, 1);
+              }
+            }
+
             if (previewObj.Status != ApplicationObject.State.Unknown)
             {
               continue; // this has already been converted and baked
@@ -303,6 +321,21 @@ await ConnectorHelpers.TryCommitReceived(
 
           RhinoDoc.LayerTableEvent += RhinoDoc_LayerChange; // reactivate the layer handler
 
+          // track the object type counts as an event before we try to receive
+          // this will tell us the composition of a commit the user is trying to convert and receive, even if it's not successfully converted or received
+          // we are capped at 255 properties for mixpanel events, so we need to check dict entries
+          var typeCountArray = typeCountDict
+            .ToArray()
+            .Select(o => new { TypeName = o.Key, Count = o.Value })
+            .OrderBy(pair => pair.Count)
+            .Reverse()
+            .Take(250);
+
+          Speckle.Core.Logging.Analytics.TrackEvent(
+            Speckle.Core.Logging.Analytics.Events.ConvertToNative,
+            new Dictionary<string, object>() { { "typeCount", typeCountArray } }
+          );
+
           // undo notes edit
           var segments = Doc.Notes.Split(new[] { "%%%" }, StringSplitOptions.None).ToList();
           Doc.Notes = segments[0];

ConnectorRhino/ConnectorRhino/ConnectorRhinoShared/UI/ConnectorBindingsRhino.Send.cs

@@ -53,6 +53,9 @@ public override async Task<string> SendStream(StreamState state, ProgressViewMod
     var commitLayers = new Dictionary<string, Layer>();
     var commitCollections = new Dictionary<string, Collection>();
 
+    // track object types for mixpanel logging
+    Dictionary<string, int> typeCountDict = new();
+
     // convert all commit objs
     foreach (var selectedId in state.SelectedObjectIds)
     {
@@ -63,6 +66,17 @@ public override async Task<string> SendStream(StreamState state, ProgressViewMod
       var reportObj = new ApplicationObject(selectedId, "Unknown");
       if (Utils.FindObjectBySelectedId(Doc, selectedId, out object obj, out string descriptor))
       {
+        // log selection object type
+        var objectType = obj.GetType().ToString();
+        if (typeCountDict.TryGetValue(objectType, out int value))
+        {
+          typeCountDict[objectType] = ++value;
+        }
+        else
+        {
+          typeCountDict.Add(objectType, 1);
+        }
+
         // create applicationObject
         reportObj = new ApplicationObject(selectedId, descriptor);
         converter.Report.Log(reportObj); // Log object so converter can access
@@ -228,10 +242,26 @@ void AddParent(Layer childLayer)
       throw new SpeckleException("Zero objects converted successfully. Send stopped.");
     }
 
+    // track the object type counts as an event before we try to send
+    // this will tell us the composition of a commit the user is trying to convert and send, even if it's not successfully converted or sent
+    // we are capped at 255 properties for mixpanel events, so we need to check dict entries
+    var typeCountArray = typeCountDict
+      .ToArray()
+      .Select(o => new { TypeName = o.Key, Count = o.Value })
+      .OrderBy(pair => pair.Count)
+      .Reverse()
+      .Take(250);
+
+    Speckle.Core.Logging.Analytics.TrackEvent(
+      Speckle.Core.Logging.Analytics.Events.ConvertToSpeckle,
+      new Dictionary<string, object>() { { "typeCount", typeCountArray } }
+    );
+
     progress.CancellationToken.ThrowIfCancellationRequested();
 
     progress.Max = objCount;
 
+    // send the commit
     var transports = new List<ITransport> { new ServerTransport(client.Account, streamId) };
 
     var objectId = await Operations.Send(
@@ -260,6 +290,7 @@ void AddParent(Layer childLayer)
     }
 
     var commitId = await ConnectorHelpers.CreateCommit(client, actualCommit, progress.CancellationToken);
+
     return commitId;
   }
 }

Core/Core/Logging/Analytics.cs

@@ -67,7 +67,17 @@ public enum Events
     /// <summary>
     /// Event triggered by the Mapping Tool
     /// </summary>
-    MappingsAction
+    MappingsAction,
+
+    /// <summary>
+    /// Event triggered when user selects object to convert to Speckle on Send
+    /// </summary>
+    ConvertToSpeckle,
+
+    /// <summary>
+    /// Event triggered when user selects object to convert to Native on Receive
+    /// </summary>
+    ConvertToNative
   }
 
   private const string MIXPANEL_TOKEN = "acd87c5a50b56df91a795e999812a3a4";

Objects/Converters/ConverterAutocadCivil/ConverterAutocadCivilShared/ConverterAutocadCivil.cs

@@ -143,7 +143,6 @@ public Base ConvertToSpeckle(object @object)
               break;
             case AcadDB.Polyline o:
               @base = o.IsOnlyLines ? PolylineToSpeckle(o) : (Base)PolycurveToSpeckle(o);
-
               break;
             case AcadDB.Polyline3d o:
               @base = PolylineToSpeckle(o);