Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(Revit): CNX-9204 add parameters to groups #3293

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Feat(Revit): CNX-9204 add parameters to groups #3293

merged 1 commit into from
Apr 22, 2024

Conversation

connorivy
Copy link
Contributor

@connorivy connorivy commented Apr 19, 2024 •
edited
Loading

Description & motivation

Add element parameters to group objects

Changes:

To-do before merge:

Screenshots:

Validation of changes:

image
After this PR, group parameters are sent with the group object to Speckle

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@connorivy connorivy mentioned this pull request Apr 19, 2024
Closed
6 tasks
@connorivy connorivy requested a review from AlanRynne April 19, 2024 14:21
AlanRynne
AlanRynne approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️ Fantastic, I love one-liner new features! 😄

@AlanRynne AlanRynne changed the title Feat(Revit): add parameters to groups Feat(Revit): CNX-9204 add parameters to groups Apr 22, 2024
@AlanRynne AlanRynne merged commit 28a0607 into dev Apr 22, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorivy @AlanRynne