Fix(Revit) : Use speckle newtonsoft instead of System.Text.Json for in dll conflict management project #3317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Once Bilal upgraded to the connector version with dll conflict mangement, he was met with the conflict dialog option even though previosly he wasn't running into any conflicts.
Turns out that the only dependency introduced in the dll conflict manager, System.Text.Json, caused a new conflict. In this PR I replaced System.Text.Json with Speckle.Newtonsoft.
I also introduced a new way to exclude conflicts because bilal was getting a conflict between our version of RevitAPI.dll. Now we are ignoring a conflict if the conflicting dll is a Revit dll.
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References