fix(revit): exclude element params which are not visible #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teocomi
added
bug
BovineOx
approved these changes
May 1, 2024
|
Are we targeting There's a lot of dancing around to keep all our long-running branches up to date ATM so if we could target |
|
I'll let @bimgeek prioritize |
connorivy
approved these changes
May 1, 2024
AlanRynne
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://speckle.community/t/transferring-problem/10462
Debugging this community-reported bug, I noticed we're sending to Spekcle also any hidden element parameter; in this case, there are hundreds of huge parameters attached to some elements (maybe images or something else?) added, most likely via an adding.
I think we should ignore these props.
Ideally this PR would be released as hotfix sometime soon.