Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress warning dialog for potential dll conflicts #3405

Merged
merged 1 commit into from
May 13, 2024

Conversation

connorivy
Copy link
Contributor

Description & motivation

We've decided that the warning message for dll conflicts may not be necessary because we can rely on only notifying the user when a conflict happens such that an exception is thrown and the Speckle connector cannot be used.

Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections. So we will trigger the conflict resolution pop-up if an exception reaches the top-level exception handler now?

@connorivy connorivy merged commit 02af65f into dev May 13, 2024
32 checks passed
@connorivy connorivy deleted the revit/connor/supress-dll-conflict-warning branch May 13, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants