Chore(Revit): remove batch uploader from running in the background #3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BovineOx
approved these changes
May 13, 2024
There was a problem hiding this comment.
@JR-Morgan should have a sanity check but looks legit to me - we ought to have a ticket on the board though
JR-Morgan
approved these changes
May 14, 2024
AlanRynne
previously requested changes
May 14, 2024
AlanRynne
dismissed
their stale review
Made the changes myself as it was a 30 second thing.
|
Tested this locally and nothing breaks, managed to send/receive just fine without the BatchUploader as expected. |
JR-Morgan
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Batch uploader was never fully viable and should not be running in the connector because it doesn't do anything