Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocad): CNX-9237 CNX-9238 Add support for Autocad and Civil3D 2025 #3413

Merged
merged 10 commits into from
May 14, 2024

Conversation

clairekuang
Copy link
Member

@clairekuang clairekuang commented May 14, 2024

Description & motivation

Adds Autocad and Civil3D 2025 Connector and Converter projects.
Updates constants for Civil.

Validation of changes:

Sent and received in acad 2025

Checklist:

  • Update docs
  • Update Installers

@clairekuang clairekuang requested a review from AlanRynne May 14, 2024 08:52
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this locally yet but code chagnes look good.

Loving the CivilXX_OR_GREATER directives.

@@ -12,7 +12,7 @@
<PlatformTarget>x64</PlatformTarget>
<AssemblyTitle>ConnectorCivil2021</AssemblyTitle>
<Product>ConnectorCivil2021</Product>
<DefineConstants>$(DefineConstants);CIVIL2021</DefineConstants>
<DefineConstants>$(DefineConstants);CIVIL2021;CIVIL;CIVIL2021_OR_GREATER</DefineConstants>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice ♥️

@clairekuang clairekuang changed the title feat(autocad): CNX-9237 Add support for Autocad 2025 feat(autocad): CNX-9237 CNX-9238 Add support for Autocad and Civil3D 2025 May 14, 2024
@clairekuang clairekuang merged commit 3ed07ca into dev May 14, 2024
32 checks passed
@clairekuang clairekuang deleted the CNX-9237-Add-support-for-AutoCAD-2025 branch May 14, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants