-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autocad): CNX-9237 CNX-9238 Add support for Autocad and Civil3D 2025 #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecklesystems/speckle-sharp into CNX-9237-Add-support-for-AutoCAD-2025
AlanRynne
reviewed
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested this locally yet but code chagnes look good.
Loving the CivilXX_OR_GREATER directives.
@@ -12,7 +12,7 @@ | |||
<PlatformTarget>x64</PlatformTarget> | |||
<AssemblyTitle>ConnectorCivil2021</AssemblyTitle> | |||
<Product>ConnectorCivil2021</Product> | |||
<DefineConstants>$(DefineConstants);CIVIL2021</DefineConstants> | |||
<DefineConstants>$(DefineConstants);CIVIL2021;CIVIL;CIVIL2021_OR_GREATER</DefineConstants> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice
AlanRynne
approved these changes
May 14, 2024
…ecklesystems/speckle-sharp into CNX-9237-Add-support-for-AutoCAD-2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Adds Autocad and Civil3D 2025 Connector and Converter projects.
Updates constants for Civil.
Validation of changes:
Sent and received in acad 2025
Checklist: