Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add revit 2025 support to the .sln in order for installer to work #3416

Merged
merged 2 commits into from
May 16, 2024

Conversation

connorivy
Copy link
Contributor

Description & motivation

These projects were already added to All.sln and the corrosponding Revit solution filter, but the installer still assumes we are using the old .sln file, so we need to add the Revit 2025 projects to that file as well

@AlanRynne
Copy link
Contributor

All tests are passing now. We still have a ref to xUnitRevit projects, which are not part of the mono-repo.

You must have it checked out in the right place. You were also missing the TestGenerator project in the Revit solution.

I must acknowledge this is a PITA 🙇🏼‍♂️

Lets hope it's not for long 🤞🏻

Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but this should go into main ;) Swapping the target branch now

@AlanRynne AlanRynne changed the base branch from dev to main May 15, 2024 08:34
@AlanRynne AlanRynne requested a review from JR-Morgan May 15, 2024 08:34
@connorivy connorivy merged commit f177a4c into main May 16, 2024
32 checks passed
@connorivy connorivy deleted the revit/connor/update-sln-for-revit-2025 branch May 16, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants