Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promoted CS8618 to warning (dev) #3453

Merged
merged 1 commit into from
May 30, 2024
Merged

Promoted CS8618 to warning (dev) #3453

merged 1 commit into from
May 30, 2024

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented May 30, 2024 •
edited
Loading

This was a change we have already made for DUI3, I wanted to replicate in dev also for the sake of Objects

@JR-Morgan JR-Morgan requested a review from AlanRynne May 30, 2024 12:12
@JR-Morgan JR-Morgan changed the title Promoted CS8618 to warning Promoted CS8618 to warning (dev) May 30, 2024
AlanRynne
AlanRynne approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Since we already did these changes in dui3/alpha, some conflicts are going to arise.

Could you open a temp branch from dev, merge dui3/alpha in and resolve any conflicts there? 🙏🏼

The sooner we propagate this both ways the better :)

@AlanRynne AlanRynne mentioned this pull request May 30, 2024
Merged
@JR-Morgan JR-Morgan merged commit c4b928c into dev May 30, 2024
32 checks passed
@JR-Morgan JR-Morgan deleted the jrm/CS8618 branch May 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JR-Morgan @AlanRynne