Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNX-9443 Rhino Compute units set as mm #3460

Merged
merged 5 commits into from
Jun 3, 2024
Merged

CNX-9443 Rhino Compute units set as mm #3460

merged 5 commits into from
Jun 3, 2024

Conversation

AlanRynne
Copy link
Contributor

@AlanRynne AlanRynne commented May 31, 2024 •
edited
Loading

Important

This PR targets main and should be released as part of the next hotfix 2.19.1

https://spockle.atlassian.net/browse/CNX-9443

  • Adds RHINO7_OR_GREATER to grasshopper
  • Fixes GetVersionedAppName to use Loader equivalent. Did not delete it but flagged it as obsolete
  • Fixed exception on initial open event in headless document run.

@AlanRynne AlanRynne modified the milestone: 2.14 May 31, 2024
oguzhankoral
oguzhankoral approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! LGTM

@AlanRynne AlanRynne merged commit dfb6d2e into main Jun 3, 2024
32 checks passed
@AlanRynne AlanRynne deleted the CNX-9443-Rhino-Compute-units-set-as-mm branch June 3, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamhathcock adamhathcock adamhathcock approved these changes

@oguzhankoral oguzhankoral oguzhankoral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanRynne @adamhathcock @oguzhankoral