WEB-1031 Provide test utils from sdk #3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanRynne
approved these changes
Jun 4, 2024
gjedlicska
approved these changes
Jun 5, 2024
| public static string GetSpeckleServerUrl() | ||
| { | ||
| return GetAppSettings()?.SpeckleServerUrl | ||
| ?? TryGetEnvironmentVariable("SPECKLE_SERVER_URL") |
There was a problem hiding this comment.
all the other methods use the GetEnvVariable method, why is this using the TryGet... ?
There was a problem hiding this comment.
just how I went about doing the fallback to http://127.0.0.1:3000! we don't appear to tolerate/provide fallbacks for the others
although it is a bit silly when you say it like that, open to other ways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
We are preparing to release support for "test automations" alongside utils for using them while developing local functions. For this first draft, we'd like to release the utils via the SDKs so that we can provide updates to consumers as test automations develop further.
Changes:
TestAutomateEnvrionmentandTestAutomateUtilstoSpeckle.Automate.Sdk.Test. To be used by the dotnet function example on release.