Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(Archicad): Properties not showing in viewer #3472

Merged
merged 3 commits into from
Jun 12, 2024
Merged

bug(Archicad): Properties not showing in viewer #3472

merged 3 commits into from
Jun 12, 2024

Conversation

jozseflkiss
Copy link
Contributor

@jozseflkiss jozseflkiss commented Jun 4, 2024 •
edited
Loading

Description & motivation

Fix of #3471.

Changes:

elementProperties and componentProperites properties added to Archicad.DirectShape class
GetElementBaseData changed to be able to work with JSON raw data.

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

@jozseflkiss jozseflkiss changed the base branch from main to dev June 4, 2024 14:49
József L. Kiss added 2 commits June 4, 2024 16:58
@AlanRynne AlanRynne self-assigned this Jun 5, 2024
@AlanRynne AlanRynne merged commit c4cd55e into specklesystems:dev Jun 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

Assignees

@AlanRynne AlanRynne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jozseflkiss @AlanRynne