Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host app non-central managed #3543

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Host app non-central managed #3543

merged 5 commits into from
Jul 1, 2024

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Jun 28, 2024

Now we're locally moving host app versions to converters/connectors. Everything else is centrally managed

AlanRynne
AlanRynne previously approved these changes Jul 1, 2024
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really required? I fear we're going to end with +20 Package.props files, which is just going to make everything more confusing.

@AlanRynne AlanRynne dismissed their stale review July 1, 2024 08:45

Meant to comment, not approve

@adamhathcock
Copy link
Member Author

Is this really required? I fear we're going to end with +20 Package.props files, which is just going to make everything more confusing.

Well, it's either this or get rid of Central management altogether. It's already doing this, btw it's just now reflection in the solution.

@AlanRynne
Copy link
Member

I'm not sure we need or want to centrally manage every package in a way that's not centralized.

My take on this would be:

  • We centrally manage everything that has to have a consistent version across the entire monorepo
  • We manually manage dependencies that are "per-project" (host API versions specifically)

I'm not sure what's the benefit of having different Directory.Packages.props files just for 2 projects at a time. Specially considering the converter also needs the same version as the connector and it lives elsewhere.

We seem to already have 3 different package.props files just for autocad alone.

That being said, I'm happy to be convinced otherwise 😉

Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Live reviewed with Adam with some added changes 🙂

@adamhathcock adamhathcock changed the title Add Autocad versions like file system Host app non-central managed Jul 1, 2024
@adamhathcock adamhathcock merged commit 763037c into dui3/alpha Jul 1, 2024
33 checks passed
@adamhathcock adamhathcock deleted the all-autocad-versions branch July 1, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants