Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUI3-71 receive bindings and receive geometry #3544

Merged
merged 9 commits into from
Jul 2, 2024

Conversation

connorivy
Copy link
Contributor

@connorivy connorivy commented Jun 28, 2024

Description & motivation

Changes:

Connectors / Revit

  • Added receive binding (pretty much copied from Rhino)
  • Modified service registrations for new types
    • Added default traversal function
  • Registered a run on thread method that uses the Revit Async package
    • Running on main thread alone is not sufficient
  • Added simple host object "builder" that just opens a transaction, traverses, receives, and then commits the transaction
  • Copied transaction manager from dui2 connector

Converter / Revit

  • added import method next to export method on referencePointConverter (and interface)
  • Changed name of 'RevitRootToHostConverter' which implements 'IRootToSpeckleConverter' to accurately reflect the implemented interface (aka replaced ToHost with ToSpeckle)
  • Added toHost scaling service to mirror toSpeckle scaling service

Converter / Revit / ToHost

  • implemented ITypedConverter interface for several types of geometries
  • added a modelCurve topLevel converter to be able to actually use the typedConverters

Converter / Revit / ToSpeckle

  • I moved a bunch of files into this 'toSpeckle' folder to mirror the folder structure of Rhino

To-do before merge:

Screenshots:

Validation of changes:

receiving works for model lines of various types

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@connorivy connorivy requested a review from oguzhankoral June 28, 2024 14:08
Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comments on binding for now, will test converters later and review again.

@oguzhankoral oguzhankoral requested a review from BovineOx June 28, 2024 18:01
Copy link
Contributor

@BovineOx BovineOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty good. I have some concern around the correct lifetime for the transaction (but i could be fine). I've also some points where I'd like @clairekuang to be involved and perhaps for between you, you raise any necessary tickets for gaps.

@BovineOx
Copy link
Contributor

BovineOx commented Jul 1, 2024

Oh yeah and the Dispose()/lack of using/disabling the warning

Copy link
Contributor

@BovineOx BovineOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a couple of points

@connorivy connorivy enabled auto-merge (squash) July 2, 2024 16:56
@connorivy connorivy disabled auto-merge July 2, 2024 19:31
@connorivy connorivy dismissed stale reviews from JR-Morgan and oguzhankoral July 2, 2024 19:32

changes were addressed

@connorivy connorivy merged commit 56496ee into dui3/alpha Jul 2, 2024
33 checks passed
@connorivy connorivy deleted the revit/connor/add-receive-bindings branch July 2, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants