Fix: resolved issue sending pipes from Revit #3560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
When attempting to upload a model from Revit using the connector, it was failing when attempting to upload certain pipe objects. We managed to isolate the pipe elements and attempt to upload them in isolation. When we tried this we were getting "Object reference not set to an instance of an object" errors. Upon debugging the connector locally. We found this error was occuring when creating RevitPipe objects. When setting the systemName value an error was occuring as there was no MEPSystem associated with the pipe. To fix this we added a null check against the MEPSystem of the revitPipe object. If the MEPSystem doesnt exist the systemName defaults to an empty string.
Fixes #3551
Changes:
Added a null coalescing check when adding systemName value when creating RevitPipe objects. This allows pipes to be creating and sent to Speckle if not connected to a MEPSystem.
Screenshots:
Validation of changes:
Checklist:
References
Issue: #3559
Forum Post: https://speckle.community/t/revit-pipes-failing-to-export/10139