Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: resolved issue sending pipes from Revit #3560

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

EuanKeyframe
Copy link
Contributor

@EuanKeyframe EuanKeyframe commented Jul 5, 2024

Description & motivation

When attempting to upload a model from Revit using the connector, it was failing when attempting to upload certain pipe objects. We managed to isolate the pipe elements and attempt to upload them in isolation. When we tried this we were getting "Object reference not set to an instance of an object" errors. Upon debugging the connector locally. We found this error was occuring when creating RevitPipe objects. When setting the systemName value an error was occuring as there was no MEPSystem associated with the pipe. To fix this we added a null check against the MEPSystem of the revitPipe object. If the MEPSystem doesnt exist the systemName defaults to an empty string.

Fixes #3551

Changes:

Added a null coalescing check when adding systemName value when creating RevitPipe objects. This allows pipes to be creating and sent to Speckle if not connected to a MEPSystem.

Screenshots:

image
image_360

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.

References

Issue: #3559
Forum Post: https://speckle.community/t/revit-pipes-failing-to-export/10139

Copy link
Contributor

@connorivy connorivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR

@connorivy connorivy changed the base branch from main to dev July 18, 2024 21:49
@connorivy connorivy merged commit 8dad212 into specklesystems:dev Jul 18, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants