Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsdb/navisworks/optiimisations #3565

Merged
merged 16 commits into from
Jul 18, 2024
Merged

Jsdb/navisworks/optiimisations #3565

merged 16 commits into from
Jul 18, 2024

Conversation

jsdbroughton
Copy link
Contributor

@jsdbroughton jsdbroughton commented Jul 9, 2024

Description & motivation

This PR introduces optimizations, fixes, and settings changes to improve the Navisworks connector's performance and reliability. The updates address critical issues and enhance user experience by refining conversion processes and settings management.

Changes

  • Improved handling of conversion settings.
  • Introduced multithreading for enhanced performance.
  • Extracted property management.
  • Enhanced progress handling and logging with ProgressLooper.
  • Consolidated expensive looping tasks and migrated to HashSet.
  • Added option to omit properties during conversion.
  • Fixed hierarchy regression in ad hoc selection sends to match saved selections.
  • General codebase refactoring for better maintainability.

Validation of Changes

  • Tested conversion settings and multithreading improvements.
  • Verified progress reporting accuracy with ProgressLooper.
  • Ensured performance gains with HashSet.
  • Confirmed the option to omit properties works as expected.
  • Validated the hierarchy regression fix in ad hoc selection sends.
  • Benchmarks across model sizes consistently show a 55-70% speed improvement.

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change.
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a style similar to that of the existing code.

@jsdbroughton jsdbroughton marked this pull request as ready for review July 9, 2024 17:02
@JR-Morgan JR-Morgan merged commit 9855d2e into dev Jul 18, 2024
31 of 32 checks passed
@JR-Morgan JR-Morgan deleted the jsdb/navisworks/optiimisations branch July 18, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants