[CNX-9823] add material quantity attribute to archicad elements #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… commit for add-on only)
- Updated ArchicadConnector to deserialise and submit material quantities - Removed superfluous Material property names - Ensure MaterialQuantity members initialised to default values
JR-Morgan
requested changes
Jul 9, 2024
ConnectorArchicad/ConnectorArchicad/Converters/Converters/Utils.cs
Outdated
Show resolved
Hide resolved
ConnectorArchicad/AddOn/Sources/AddOn/Commands/GetDataCommand.cpp
Outdated
Show resolved
Hide resolved
JR-Morgan
reviewed
Jul 9, 2024
ConnectorArchicad/AddOn/Sources/AddOn/Commands/GetDataCommand.cpp
Outdated
Show resolved
Hide resolved
Removed C++17 use to allow AC25/26 builds Changed documentation comment style in C# to MS XML
JR-Morgan
approved these changes
Jul 11, 2024
r-wessel
deleted the
CNX-9823-Add-MaterialQuantity-attribute-to-Archicad-elements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds material quantities equivalent to the Revit output
Only measures:
…elements.