fix(civil3d): added units to civil classes missing them #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BovineOx
approved these changes
Jul 25, 2024
| @@ -1229,7 +1238,11 @@ private CivilCalculatedLink CalculatedLinkToSpeckle(CalculatedLink link) | |||
| specklePoints.Add(specklePoint); | |||
| } | |||
|
|
|||
| CivilCalculatedLink speckleLink = new(codes, specklePoints); | |||
| CivilCalculatedLink speckleLink = new(codes, specklePoints) | |||
There was a problem hiding this comment.
Seems a bit odd to be setting units outside of the constructor, is it optional?
There was a problem hiding this comment.
yes they are currently optional
clairekuang
deleted the
CNX-9900-Performance-Everything-sends-all-objects-at-unknown-scale-relative-to-sent-units
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds units to some civil classes added in 2.20 that were msising them, as well as the civil3d conversions.